Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff lines should preserve foreground colors #173

Open
jerryyin opened this issue Sep 26, 2021 · 0 comments
Open

Diff lines should preserve foreground colors #173

jerryyin opened this issue Sep 26, 2021 · 0 comments

Comments

@jerryyin
Copy link

jerryyin commented Sep 26, 2021

Description

Right now diff lines:

  • Only have solid background color
  • Does not have foreground color so syntax highlighting is off

This is so that lines retain their syntax highlighting in the diff mode, while the backgrounds are highlighted.

Example

To illustrate the point, solarized color scheme allow diff mode preserve the foreground color while having non-eye-popping color from background, gruvbox should be able to do it too.

image

For solarized implementation refer to this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant