From ad6707911d0141e12ca155a63b985b3ec65d2149 Mon Sep 17 00:00:00 2001 From: Zhian Kamvar Date: Sun, 28 Aug 2016 16:17:27 -0700 Subject: [PATCH] update CRAN comments --- README.md | 4 ++-- cran-comments.md | 30 +++++++++++++++++++++++++++--- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 7107b6e7..8a2c3133 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ # Poppr version 2 In development: -[![Build Status](https://travis-ci.org/grunwaldlab/poppr.svg?branch=latex-fix)](https://travis-ci.org/grunwaldlab/poppr) -[![Coverage Status](https://coveralls.io/repos/grunwaldlab/poppr/badge.svg?branch=latex-fix)](https://coveralls.io/r/grunwaldlab/poppr?branch=latex-fix) +[![Build Status](https://travis-ci.org/grunwaldlab/poppr.svg?branch=master)](https://travis-ci.org/grunwaldlab/poppr) +[![Coverage Status](https://coveralls.io/repos/grunwaldlab/poppr/badge.svg?branch=master)](https://coveralls.io/r/grunwaldlab/poppr?branch=master) On CRAN: [![Downloads from Rstudio mirror per month](http://cranlogs.r-pkg.org/badges/poppr)](http://www.r-pkg.org/pkg/poppr) diff --git a/cran-comments.md b/cran-comments.md index 52b86b4f..bf86edc6 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,8 +1,8 @@ ## Test environments -* local OS X install, R 3.3.0 -* ubuntu 12.04 (on travis-ci), devel [2016-06-08 r70734] and R 3.3.0 -* win-builder (devel [2016-06-08 r70728]) +* local OS X install, R 3.3.1 +* ubuntu 12.04 (on travis-ci), devel [2016-08-28 r71162] and R 3.3.1 +* win-builder (devel [2016-08-27 r71160]) ## R CMD check results @@ -21,6 +21,30 @@ Found the following (possibly) invalid URLs: This is indeed a valid URL +## valgrind + +There is currently a valgrind note on CRAN. It was brought up on 2016-06-08. +I responded on 2016-06-09: + +> It was my understanding that this was an artifact due to the behavior of +> OpenMP and valgrind (possibly summarized in a similar situation here: +> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36298), which is why the leak +> summary does not show any memory that is definitely or indirectly lost. +> +> FWIW, the summary points to line 255 in the code, which is in the middle of an +> OMP pragma statement: +> https://github.com/grunwaldlab/poppr/blob/fda8606ab9c9965 +> 42cabc8c9092e024ceb86e4cd/src/bitwise_distance.c#L254-L259 + +Kurt's response on 2016-06-13: + +> Right. So there's perhaps nothing you can do about this. +> +> On its way to CRAN ... +> +> Best +> -k + ## Downstream dependencies - popprxl: OK