diff --git a/cran-comments.md b/cran-comments.md index 8a968757..d8a23109 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -2,19 +2,36 @@ This is a resubmission. -I previously submitted a day ago and subsequently found a silent user-facing bug -that impacts users negatively. This update fixes that bug. +This submission fixes two bugs: + + - Parallel code that threw an error on Fedora systems was serialized + (https://github.com/grunwaldlab/poppr/issues/138) + - A significant and silent user-facing bug was fixed + (https://github.com/grunwaldlab/poppr/issues/136) ## Test environments * local OS X install, R 3.3.3 -* ubuntu 12.04 (on travis-ci), devel (2017-04-07 r72495) and R 3.3.3 -* winbuilder R version 3.4.0 beta (2017-04-07 r72496) +* ubuntu 12.04 (on travis-ci), devel (2017-04-12 r72509) and R 3.3.3 +* winbuilder R version 3.4.0 beta (2017-04-12 r72509) * Rhub fedora-gcc-devel (2017-04-08 r72499) ## R CMD check results -All good on the above platforms. +On winbuilder: +> +> * checking CRAN incoming feasibility ... NOTE +> Maintainer: 'Zhian N. Kamvar ' +> +> Days since last update: 3 + +I have been in communication with Professor Ligges about this update. + +## Solaris SPARC + +There is currently an ERROR on poppr's results, but this originates in another +package. I have submitted code to fix this: +https://github.com/thibautjombart/adegenet/pull/176 ## valgrind diff --git a/man/is.clone.Rd b/man/is.clone.Rd index 2d828ace..c298bee6 100644 --- a/man/is.clone.Rd +++ b/man/is.clone.Rd @@ -24,7 +24,8 @@ a \linkS4class{genclone} object will always be a valid be a valid \linkS4class{genlight} object. } \examples{ -(sc <- as.snpclone(glSim(100, 1e3, ploid=2))) +(sc <- as.snpclone(glSim(100, 1e3, ploid=2, parallel = FALSE), + parallel = FALSE, n.cores = 1L)) is.snpclone(sc) is.clone(sc) data(nancycats)