-
Notifications
You must be signed in to change notification settings - Fork 165
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #95 from tagantroy/master
Fix problem with underscores in rpc names
- Loading branch information
Showing
4 changed files
with
61 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
compiler/src/test/java/io/grpc/kotlin/generator/protoc/ProtoMethodNameTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package io.grpc.kotlin.generator.protoc | ||
|
||
import com.google.common.truth.Truth.assertThat | ||
import org.junit.Test | ||
import org.junit.runner.RunWith | ||
import org.junit.runners.JUnit4 | ||
|
||
/** Tests for [ProtoMethodName]. */ | ||
@RunWith(JUnit4::class) | ||
class ProtoMethodNameTest { | ||
@Test | ||
fun toMemberSimpleNameWithSingleUnderscore(){ | ||
assertThat(ProtoMethodName("say_hello").toMemberSimpleName()) | ||
.isEqualTo(MemberSimpleName("sayHello")) | ||
} | ||
|
||
@Test | ||
fun toMemberSimpleNameWithMultipleUnderscores(){ | ||
assertThat(ProtoMethodName("say_hello_again").toMemberSimpleName()) | ||
.isEqualTo(MemberSimpleName("sayHelloAgain")) | ||
} | ||
|
||
@Test | ||
fun toMemberSimpleNameWithRecommendedNamingStyle(){ | ||
assertThat(ProtoMethodName("SayHello").toMemberSimpleName()) | ||
.isEqualTo(MemberSimpleName("sayHello")) | ||
} | ||
} |
9 changes: 9 additions & 0 deletions
9
compiler/src/test/proto/testing/rpc_name_contains_underscore.proto
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
syntax = "proto3"; | ||
package io.grpc.testing.underscore; | ||
option java_multiple_files = true; | ||
service NameContainsUnderscore { | ||
rpc say_hello (HelloRequest) returns (HelloReply); | ||
rpc say_hello_again (HelloRequest) returns (HelloReply); | ||
} | ||
message HelloRequest {} | ||
message HelloReply {} |