api: Javadoc changes for io.grpc.LoadBalancer method signatures #11623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Duration" This reverts commit ab97045.
|
Below points have been addressed: javadoc for public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses)
javadoc for public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses)
|
| @@ -179,12 +179,12 @@ public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) { | |||
| * EquivalentAddressGroup} addresses should be considered equivalent but may be flattened into a | |||
| * single list if needed. | |||
| * | |||
| * <p>Implementations can choose to reject the given addresses by returning {@code false}. | |||
| * <p>Implementations can choose to reject the given addresses by returning {@code UNAVAILABLE}. | |||
There was a problem hiding this comment.
Replace with {@code Status.UNAVAILABLE} . Also below.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
…d and related changes
kannanjgithub
requested changes
Nov 4, 2024
| @@ -263,7 +263,7 @@ public void shutdown() { | |||
| new EquivalentAddressGroup(new SocketAddress(){})); | |||
| ResolvedAddresses addresses = ResolvedAddresses.newBuilder().setAddresses(servers) | |||
| .setAttributes(attrs).build(); | |||
| balancer.handleResolvedAddresses(addresses); | |||
There was a problem hiding this comment.
We discussed not to change this test.
| @@ -197,7 +201,7 @@ public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses) { | |||
| return unavailableStatus; | |||
| } else { | |||
| if (recursionCount++ == 0) { | |||
| handleResolvedAddresses(resolvedAddresses); | |||
| //handleResolvedAddresses(resolvedAddresses); | |||
There was a problem hiding this comment.
Why have you commented this out?
| // parent policies, where they fail to call switchTo(). So we will use the exception to try | ||
| // to notice those bugs quickly, as it will fail very loudly. | ||
| throw new IllegalStateException( | ||
| "GracefulSwitchLoadBalancer must switch to a load balancing policy before handling" |
There was a problem hiding this comment.
This must be added instead to acceptResolvedAddresses.
| @@ -240,9 +240,8 @@ public void handleResolvedAddresses_delegatesToAcceptResolvedAddresses() { | |||
|
|
|||
| LoadBalancer balancer = new LoadBalancer() { | |||
| @Override | |||
| public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses) { | |||
| public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) { | |||
| resultCapture.set(resolvedAddresses); | |||
There was a problem hiding this comment.
Why this change? Revert.
There was a problem hiding this comment.
Rolled back please review
kannanjgithub
approved these changes
Nov 6, 2024
kannanjgithub
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javadoc changes for io.grpc.LoadBalancer
Fixes #11194