Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct way to check internet connection goes away #7841

Open
ukai opened this issue Nov 14, 2024 · 1 comment
Open

correct way to check internet connection goes away #7841

ukai opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. Type: Question

Comments

@ukai
Copy link

ukai commented Nov 14, 2024

When internet connection goes away in the long running process, grpc returns

code = Unavailable desc = last connection error: connection error: desc = "transport: Error while dialing: dial tcp: lookup remotebuildexecution.googleapis.com: no such host"

(using google.golang.org/api/transport/grpc's DialPool).

How should we heck this error type?
I think we want to retry for Unavailable, but we'd like to report this error to the user without retry.

@arjan-bal
Copy link
Contributor

@ukai do you know how DialPool handles failures? Does it transparently retry using a new ClientConn/Channel from the pool when one ClientConn fails? If yes, then you would always see a DNS resolution failure when sending the first request on a new ClientConn.

@arjan-bal arjan-bal added Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. and removed Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. Type: Question
Projects
None yet
Development

No branches or pull requests

2 participants