Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Outlier Detection to be able to use it outside of xDS #7647

Open
zasweq opened this issue Sep 18, 2024 · 0 comments
Open

Move Outlier Detection to be able to use it outside of xDS #7647

zasweq opened this issue Sep 18, 2024 · 0 comments
Assignees
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Internal Cleanup Refactors, etc

Comments

@zasweq
Copy link
Contributor

zasweq commented Sep 18, 2024

Currently, Outlier Detection currently lives in xds/internal/balancer. This means unless you import the full xds package, a user cannot deploy this through a service config directly on their channel.

From https://github.com/grpc/proposal/blob/master/A50-xds-outlier-detection.md#non-xds-specific-lb-policy: "
We decided to implement outlier detection as a generic LB policy instead of making it xDS-specific, possibly as part of the xds_cluster_impl policy. The outlier detection logic has no real dependency on xDS, and making it generic in this way allows us to provide its value to more of our users."

A proposed solution is to move this to internal/balancer, import that from balancer/outlierdetection and provide an exported Name from balancer/outlierdetection as well.

@zasweq zasweq added the Type: Feature New features or improvements in behavior label Sep 18, 2024
@zasweq zasweq self-assigned this Sep 18, 2024
@zasweq zasweq added Type: Internal Cleanup Refactors, etc P2 and removed Type: Feature New features or improvements in behavior labels Sep 18, 2024
@purnesh42H purnesh42H added the Area: xDS Includes everything xDS related, including LB policies used with xDS. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

No branches or pull requests

2 participants