-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional fields support #21
Comments
haven't run into this before. let me have a look and get back to you later. |
👋 @vgarvardt getting around the error itself is simple. But that doesn't mean the output code will have full support of the optional semantic in proto3. So I don't think it's the right thing to do. The current situation is that the support of proto2 optional/require is not properly implemented in this generator. To achieve the real support of optional field in proto3, might as well solve the proto2 problem at the same time. So there will be quite a bit of work needs to be done. |
I'm still very interested in this and may spend some time helping with the implementation, but I'll need your guidance. Maybe you can describe the job that needs to be done for a proper implementation, or at least the first steps so I could try to work on it and let you review PRs if you do not have to work on it. |
@vgarvardt I just let |
yup, what @yinheli suggested will unblock you for now. @vgarvardt. I was gonna start working on it but got distracted to other priorities. Free free to start thinking about it before the implementation. I'll guide you through |
any updates? It will make usable this generator. It is really sucks to use grpc-web instead.... |
any updates? |
1 similar comment
any updates? |
As of protobuf 3.15
optional
fields are available, but they are not supported by the generator:test/optional/v1/has_optional_field.proto
contents:The text was updated successfully, but these errors were encountered: