Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition types #54

Open
Juraj-Masiar opened this issue Jan 8, 2021 · 1 comment
Open

Definition types #54

Juraj-Masiar opened this issue Jan 8, 2021 · 1 comment

Comments

@Juraj-Masiar
Copy link

Hello,
I've just created definition types pull request for this project:
DefinitelyTyped/DefinitelyTyped#50491

If you know what that actually is and if you have time, feel free to check it out!
This is the first time I've created definition types for a project and I have to say it took me much longer than I expected. Especially considering the super simple API here...

I will close this issue once it gets merged. If someone wants to be co-author, please let me know! More info about being an owner here.

@Juraj-Masiar
Copy link
Author

Hello again,
I've updated TypeScript definition files for the version 6.
If someone wants to review it or upgrade it, please do so:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55292/files

I'm no expert on definition files so I'm pretty sure there is room for improvement. I've only tested in on my own use-case where it works fine (better than before).
Thanks!

@Juraj-Masiar Juraj-Masiar reopened this Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant