Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comments functionality #996

Closed
5 tasks done
malachig opened this issue Feb 9, 2024 · 1 comment · Fixed by #1108
Closed
5 tasks done

Improve comments functionality #996

malachig opened this issue Feb 9, 2024 · 1 comment · Fixed by #1108

Comments

@malachig
Copy link
Member

malachig commented Feb 9, 2024 •
edited by acoffman
Loading

In adding some comments to a variant page in CIViC v2 I noticed several limitations compared to what we used to be able to do in CIViC v1.

https://civicdb.org/variants/4415/comments

  • Markdown is no longer rendered
  • The "Preview" view doesn't seem to do anything.
  • You can no longer expand the size of the comment window. For complex comments this makes it hard to check for errors/consistency.
  • A user can no longer delete their own comment. If you make any mistakes, all you can do is leave another comment.
  • The comments page in the admin interface gives an error: HTTP ERROR 500. So you can't delete a messy comment there either.
@acoffman acoffman mentioned this issue Aug 23, 2024
Merged
@acoffman
Copy link
Member

acoffman commented Aug 23, 2024 •
edited
Loading

All of these points are addressed in #1108 and will be fixed when it is deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to commenting griffithlab/civic-v2
2 participants
@acoffman @malachig