Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several enum select form fields (AMP, ACMG, and ClinGen code) require better option sorting #981

Open
jmcmichael opened this issue Jan 16, 2024 · 0 comments
Assignees
Labels
enhancement PR Label for improvements to existing functionality. Will appear in release notes.

Comments

@jmcmichael
Copy link
Contributor

Several of the enum-select fields require better sorting of their options:

  • amp-category-select: order by tier (maybe group by tiers using nested menu option)
  • clingen-code-select: order by strength, also some options might be missing
  • acmg-code-select: also appears unordered

Currently the fields do not perform any of their own sorting, just iterating through the enum object generated from the GQL schema. Since field's options are generated from observables, we can just add a map operator to perform the sorting.

@jmcmichael jmcmichael added the enhancement PR Label for improvements to existing functionality. Will appear in release notes. label Jan 16, 2024
@jmcmichael jmcmichael self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PR Label for improvements to existing functionality. Will appear in release notes.
Projects
None yet
Development

No branches or pull requests

1 participant