Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table virtual scroll does not work in some situations #1062

Open
jmcmichael opened this issue May 20, 2024 · 0 comments
Open

table virtual scroll does not work in some situations #1062

jmcmichael opened this issue May 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jmcmichael
Copy link
Contributor

jmcmichael commented May 20, 2024

Entity tables virtual scroll feature will not trigger a fetch request if the table body is tall enough such that the initial row query does not sufficiently populate its full height with rows. The virtual scroll code fetch request is only triggered when its rendered rows container approaches the bottom of the displayed rows container. Its logic assumes that the rendered row container will be larger than the displayed row container, and won't trigger if that is not the case.

This could be fixed by adding an additional check in one of the later Angular lifecycle hooks, to check these container heights after the initial query has rendered its rows, and issue an additional fetch more query if the rendered row container is shorter than the displayed rows container.

A quick fix would be to increase the count of each table's initial loaded rows from 25 to a quantity that will ensure enough rows are populated even for very tall tables.

This can be tested by using the browser zoom feature to zoom out enough such that the tables will display more than 25 rows.

@jmcmichael jmcmichael added the bug Something isn't working label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant