From 11427ca166f25b0f7b176d39c7f3a0eec8cb580c Mon Sep 17 00:00:00 2001
From: Adam Coffman <acc@fastmail.com>
Date: Thu, 22 Aug 2024 11:57:35 -0500
Subject: [PATCH 1/2] add ncit information to factor variant card on mp detail
 page

---
 ...lar-profile-factor-variant-card.component.html | 15 +++++++++++++++
 ...cular-profile-factor-variant-card.component.ts |  2 ++
 2 files changed, 17 insertions(+)

diff --git a/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.html b/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.html
index 0db7fbe0d..6b05cb049 100644
--- a/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.html
+++ b/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.html
@@ -111,6 +111,21 @@
           </nz-col>
         </nz-row>
       </nz-col>
+      <nz-col [nzSpan]="24">
+        <ng-container *ngIf="variant.ncitId; else noNcit">
+          <cvc-ncit-details
+            [ncitDetails]="variant.ncitDetails"></cvc-ncit-details>
+        </ng-container>
+        <ng-template #noNcit>
+          <nz-col [nzSpan]="24">
+            <nz-card nzTitle="">
+              <cvc-empty-revisable
+                notification="Not available, please provide an NCIt Code">
+              </cvc-empty-revisable>
+            </nz-card>
+          </nz-col>
+        </ng-template>
+      </nz-col>
     </nz-row>
   </nz-card>
 }
diff --git a/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.ts b/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.ts
index b0950c506..3ca84e3c6 100644
--- a/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.ts
+++ b/client/src/app/components/molecular-profiles/molecular-profile-factor-variant-card/molecular-profile-factor-variant-card.component.ts
@@ -22,6 +22,7 @@ import { CvcCoordinatesCardModule } from '@app/components/variants/coordinates-c
 import { NzSpaceModule } from 'ng-zorro-antd/space'
 import { CvcFeatureTagModule } from '@app/components/features/feature-tag/feature-tag.module'
 import { CvcFeatureVariantTagModule } from '@app/components/shared/feature-variant-tag/feature-variant-tag.module'
+import { CvcNcitDetailsComponent } from '@app/components/factors/ncit-details/ncit-details.component'
 
 @Component({
   selector: 'cvc-mp-factor-variant-card',
@@ -50,6 +51,7 @@ import { CvcFeatureVariantTagModule } from '@app/components/shared/feature-varia
     CvcMolecularProfileTagModule,
     CvcCoordinatesCardModule,
     CvcFeatureVariantTagModule,
+    CvcNcitDetailsComponent,
   ],
 })
 export class CvcMolecularProfileFactorVariantCardComponent implements OnInit {

From f5cce6991ea7b2f5fbcc11a5135018a1c5597ea4 Mon Sep 17 00:00:00 2001
From: Adam Coffman <acc@fastmail.com>
Date: Thu, 22 Aug 2024 11:59:26 -0500
Subject: [PATCH 2/2] remove duplicate ncit box from variant summary page

---
 .../factor-variant-summary.page.html          | 24 +++++++------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/client/src/app/components/variants/factor-variant-summary/factor-variant-summary.page.html b/client/src/app/components/variants/factor-variant-summary/factor-variant-summary.page.html
index 76f3dd204..55f1008b2 100644
--- a/client/src/app/components/variants/factor-variant-summary/factor-variant-summary.page.html
+++ b/client/src/app/components/variants/factor-variant-summary/factor-variant-summary.page.html
@@ -58,21 +58,6 @@
             </nz-descriptions-item>
           </nz-descriptions>
         </nz-col>
-        <ng-container *ngIf="variant.ncitId; else noNcit">
-          <nz-col [nzSpan]="24">
-            <cvc-ncit-details
-              [ncitDetails]="variant.ncitDetails"></cvc-ncit-details>
-          </nz-col>
-        </ng-container>
-        <ng-template #noNcit>
-          <nz-col [nzSpan]="24">
-            <nz-card nzTitle="">
-              <cvc-empty-revisable
-                notification="Not available, please provide an NCIt Code">
-              </cvc-empty-revisable>
-            </nz-card>
-          </nz-col>
-        </ng-template>
       </nz-row>
     </nz-col>
 
@@ -155,6 +140,15 @@
               [ncitDetails]="variant.ncitDetails"></cvc-ncit-details>
           </nz-col>
         </ng-container>
+        <ng-template #noNcit>
+          <nz-col [nzSpan]="24">
+            <nz-card nzTitle="">
+              <cvc-empty-revisable
+                notification="Not available, please provide an NCIt Code">
+              </cvc-empty-revisable>
+            </nz-card>
+          </nz-col>
+        </ng-template>
       </nz-row>
     </nz-col>
     <!-- END RIGHT COL -->