feat!: migrate to new slider, fix new slider styles #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
qradle-yndx
changed the title
NikitaCG
requested changes
Aug 9, 2024
| @@ -4,7 +4,7 @@ import {MobileContext} from '../../context/mobileContext'; | |||
| import {HeaderSliderBlockProps, SliderType} from '../../models'; | |||
| import {block} from '../../utils'; | |||
| import Header from '../Header/Header'; | |||
| import {SliderBlock} from '../index'; | |||
| import {SliderNewBlock as SliderBlock} from '../unstable'; | |||
There was a problem hiding this comment.
if it is a breaking change I think we need to delete old slider and use new like as the main one
qradle-yndx
force-pushed
the
feat/migrate-to-new-slider
branch
from
cc221d7
to
675e730
Compare
qradle-yndx
force-pushed
the
feat/migrate-to-new-slider
branch
2 times, most recently
from
4b46509
to
7ec25eb
Compare
* fix: slider a11y * fix: more slider a11y features * fix: requested changes and fixes * fix: removed extra attribute * fix: old slider changes * fix: tests * fix: inproper in * fix: less code * fix: even less code * fix: removed auto focus on new slider * fix: requested changes * fix: spaces * fix: tests * fix: visual tests
qradle-yndx
force-pushed
the
feat/migrate-to-new-slider
branch
from
7e62f9c
to
f3efa7b
Compare
* fix: update datalens screenshots
* fix(Slider): fix items height --------- Co-authored-by: qradle <[email protected]>
* fix: fix path for correct working with sass-loader@16
* chore(main): release 5.28.3 * Update CHANGELOG.md --------- Co-authored-by: Andrey Melikhov <[email protected]>
qradle-yndx
force-pushed
the
feat/migrate-to-new-slider
branch
from
e440053
to
8d4965a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.