-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix types conflict between content_transformer and page_content #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview is ready. |
src/containers/PageConstructor/components/ConstructorItem/ConstructorItem.tsx
Outdated
Show resolved
Hide resolved
gorgeousvlad
requested changes
Aug 1, 2023
@@ -69,9 +74,7 @@ export const ConstructorBlocks: React.FC<ConstructorBlocksProps> = ({items}) => | |||
} | |||
|
|||
return blockTypes.includes(item.type) ? ( | |||
//TODO: replace ConstructorBlock (and delete it) with BlockBase when all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was it removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
NikitaCG
force-pushed
the
fix/transformer-types
branch
from
August 1, 2023 09:05
a7b464a
to
c7d12e4
Compare
yuberdysheva
previously approved these changes
Aug 1, 2023
gorgeousvlad
previously approved these changes
Aug 2, 2023
NikitaCG
dismissed stale reviews from gorgeousvlad and yuberdysheva
via
August 3, 2023 15:18
b34f4e7
NikitaCG
force-pushed
the
fix/transformer-types
branch
from
August 3, 2023 15:18
c7d12e4
to
b34f4e7
Compare
yuberdysheva
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.