Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Theme switcher, deduplicating theme values #447

Closed
wants to merge 21 commits into from

Conversation

Kyzyl-ool
Copy link
Contributor

@Kyzyl-ool Kyzyl-ool commented Jul 21, 2023

  • Разнес ThemeProvider на 2 части: ThemeContext.Provider и на GlobalThemeController. GlobalThemeController – читает значение из ближайшего ThemeContext и применяет тему к document.body.
  • Добавил также ThemeController – применяет тему только к своим потомкам, через класс yc-root.
  • В каждом Constructor есть свой ThemeController

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@Kyzyl-ool Kyzyl-ool marked this pull request as draft July 21, 2023 21:45
@Kyzyl-ool Kyzyl-ool marked this pull request as ready for review July 21, 2023 23:43
@Kyzyl-ool Kyzyl-ool closed this Jul 24, 2023
@Kyzyl-ool Kyzyl-ool deleted the kkmch/PAGECTR-96 branch July 24, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants