Add og:images generation #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure how gh-actions will work :] |
public/og-images/app-layout.jpg
Outdated
There was a problem hiding this comment.
From my point of view text is so tiny
There was a problem hiding this comment.
design of og:images not final
scripts/prepare-og-images.mjs
Outdated
| const { id } = libs[i]; | ||
| await page.goto(`http://localhost:3000/preview/${id}`, { waitUntil: 'networkidle0' }); | ||
| await page.setViewport({ width: 1200, height: 630 }); | ||
| await page.screenshot({ path: `public/og-images/${id}.jpg` }) |
There was a problem hiding this comment.
I understand that, but I don't like it. :)
There was a problem hiding this comment.
94fcdba moved to function :D
There was a problem hiding this comment.
nope, I'm talking about using headless browser :)
imsitnikov
reviewed
Apr 25, 2023
|
closed in favor of #236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
design of og:images not final