Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging problem #1091

Open
petar-dambovaliev opened this issue Aug 3, 2022 · 1 comment · May be fixed by #1072
Open

Debugging problem #1091

petar-dambovaliev opened this issue Aug 3, 2022 · 1 comment · May be fixed by #1072
Assignees
@tyranron
Labels
enhancement Improvement of existing features or bugfix
Milestone
next major

Comments

@petar-dambovaliev
Copy link

Check this code out.
It seems to me that it would be nicer, if more information was included in the panic.
Since introducing a Debug requirement on GraphQLValue would be a breaking change, so we can have a conversation about how to do it. But it is really a problem for me, because i have a bug and i don't know which type it is coming from.
@petar-dambovaliev petar-dambovaliev added the enhancement Improvement of existing features or bugfix label Aug 3, 2022
@tyranron
Copy link
Member

tyranron commented Aug 8, 2022

@petar-dambovaliev I'm going to cut such corner cases off with new machinery design in #1072, which won't contain such panics.

@tyranron tyranron self-assigned this Aug 8, 2022
@tyranron tyranron linked a pull request Aug 8, 2022 that will close this issue
Rework core traits #1072
Draft
26 tasks
@tyranron tyranron added this to the 0.16.0 milestone Aug 8, 2022
@tyranron tyranron linked a pull request Aug 8, 2022 that will close this issue
Draft
26 tasks
@tyranron tyranron modified the milestones: 0.16.0, 0.17.0 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyranron tyranron

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
next major
Development

Successfully merging a pull request may close this issue.

Rework core traits graphql-rust/juniper
2 participants
@tyranron @petar-dambovaliev