Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Improve collision resistance of allocation ids #981

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Aug 5, 2024

Allow user to allocate multiple times to a deployment within the same epoch.

Change

  • Pass ids of recently closed allocations into uniqueAllocationID() to avoid collisions with allocations open earlier in the same epoch for the same deployment.

- Effectively, allow user to allocate and reallocate to a deployment
within the same epoch
@fordN fordN self-assigned this Aug 5, 2024
@fordN fordN requested a review from dwerner August 5, 2024 22:44
@fordN fordN added the enhancement New feature or request label Aug 5, 2024
Copy link
Contributor

@dwerner dwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@fordN fordN merged commit 016bd08 into main Aug 14, 2024
10 checks passed
@fordN fordN deleted the ford/allow-same-day-reallocation branch August 14, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request indexer-common
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

2 participants