Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: fix db migration for value_aggregate from 20 to 39 digits #973

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

carlosvdr
Copy link
Contributor

@carlosvdr carlosvdr commented Jul 30, 2024

Migrations from the indexer-rs side are using the correct value at scalar_tap_ravs > value_aggregate since it uses unsigned 128bits numbers (39 digits)
We had at first in mind 64 (therefore the 20 digits) but we need to increase this to match indexer-rs
This also happens for the nonce where it is defined as 20 digits so we are specifying it in the migrations

WARNING!!!!!! do not ignore

After running this new migrations its necessary to restart TAP-AGENT

@carlosvdr carlosvdr self-assigned this Jul 30, 2024
@carlosvdr carlosvdr marked this pull request as draft July 30, 2024 16:09
@carlosvdr carlosvdr changed the title agent: fix db migration for value_aggregate from 20 t0 40 digits agent: fix db migration for value_aggregate from 20 to 39 digits Jul 31, 2024
@carlosvdr carlosvdr marked this pull request as ready for review August 2, 2024 15:44
@carlosvdr carlosvdr added bug Something isn't working TAP labels Aug 2, 2024
@carlosvdr carlosvdr requested a review from fordN August 2, 2024 15:45
@carlosvdr carlosvdr merged commit bf2f4bf into main Aug 19, 2024
10 checks passed
@carlosvdr carlosvdr deleted the fix-db-value branch August 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working TAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants