Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexer-common: Updates to deprecate old payment systems after exponential rebates contract changes #774

Merged
merged 14 commits into from
Sep 29, 2023
Merged

indexer-common: Updates to deprecate old payment systems after exponential rebates contract changes #774

merged 14 commits into from
Sep 29, 2023

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Sep 14, 2023 •
edited by tilacog
Loading

Changes

  • Move findEvent() function to TransactionManager, so it can be used in allocations resolvers. findEvent() contains the update to flexible ABI usage that was used to support the transition to exponential rebates.
  • Fix log message bug in allocations close CLI command function

Manual tests
Beta Give feedback

@fordN fordN changed the title Update allocation resolverwes to support exponential rebates contract changes indexer-common: Update allocation resolverwes to support exponential rebates contract changes Sep 14, 2023
@fordN fordN changed the title indexer-common: Update allocation resolverwes to support exponential rebates contract changes indexer-common: Update allocation resolvers to support exponential rebates contract changes Sep 14, 2023
@fordN fordN changed the title indexer-common: Update allocation resolvers to support exponential rebates contract changes indexer-common: Updates to deprecate old payment systems after exponential rebates contract changes Sep 15, 2023
@fordN
Copy link
Contributor Author

fordN commented Sep 15, 2023

Resolves #775

@tilacog tilacog self-requested a review September 18, 2023 16:43
@tilacog tilacog added this to the v0.20.23 milestone Sep 18, 2023
@tilacog
Copy link
Contributor

tilacog commented Sep 18, 2023

I'm upgrading common-ts and related dependencies in this PR: #779

@tilacog tilacog linked an issue Sep 21, 2023 that may be closed by this pull request
Remove AllocationExchange.claimMany() #775
Closed
@tilacog
Copy link
Contributor

tilacog commented Sep 21, 2023

I've merged #779 for a CI image build, enabling us to test in our testnet environment.
@fordN, could you please review my changes on that PR page?

@tilacog
Copy link
Contributor

tilacog commented Sep 21, 2023 •
edited
Loading

Blocked due to unaccounted L1/L2 contract asymmetry in common-ts

@tilacog tilacog requested review from chriswessels and hopeyen and removed request for chriswessels September 25, 2023 21:44
fordN and others added 12 commits September 29, 2023 12:29
@fordN @tilacog
common: Move findEvent to TransactionManager,use in allocation resolvers
e777495
@fordN @tilacog
cli: Fix error message logging in allocation close command
f6aed3d
@fordN @tilacog
indexer-agent: Remove rebate reward claiming
5980280 
- After the exponential rewards contract update, indexers no longer
claim rebate rewards. The steps are reduced to only require redeem().
@tilacog
*: update some dependencies to their latest versions
958de04
@tilacog
common,native: formatting
a0a8ffb
@tilacog
common: remove unused variables
f38c4fc
@tilacog
common: remove claimRebateRewards function
58bcc58
@tilacog
common: remove claimable allocations and disputeEpochs from allocatio…
d68214c 
…n resolver
@tilacog
common: remove stakingABI workaround for exponential rebates
d8d677c
@tilacog
common: log and display connectContracts original error
7f1fb24
@tilacog
*: update common-ts to v2.0.7
db142f5
@tilacog
service: update @graphql-tools/* dependencies
ea99224
@tilacog
Copy link
Contributor

tilacog commented Sep 29, 2023

Force-pushed re rebase on top of latest main

tilacog
tilacog approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@tilacog tilacog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was deployed to our testnet and run without any outstanding issues.

@tilacog tilacog merged commit 580c78d into main Sep 29, 2023
9 checks passed
@tilacog tilacog deleted the ford/allocations-cli-fixes branch September 29, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilacog tilacog tilacog approved these changes

@hopeyen hopeyen Awaiting requested review from hopeyen

Assignees
No one assigned
Labels
None yet
Projects
Indexer
Status: 🚗 Merged
Milestone
v0.20.23
Development

Successfully merging this pull request may close these issues.

Remove AllocationExchange.claimMany()
2 participants
@fordN @tilacog