fix(indexer-native): abandon neon-utils in favor of napi-6 #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we need to release the new version to use it on the other packages |
tilacog
force-pushed
the
theodus/native
branch
from
c051c16
to
f92c2f7
Compare
|
Rebased on top of latest |
Theodus
force-pushed
the
theodus/native
branch
2 times, most recently
from
3a66d76
to
2716f61
Compare
Theodus
force-pushed
the
theodus/native
branch
from
2716f61
to
50c083f
Compare
|
Stole this for #975, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was previously unable to modify indexer-native without the native module failing to self-register. Switching to napi-6 seems to resolve this issue.