-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible subgraph deployment name resolution #637
base: main
Are you sure you want to change the base?
Conversation
Nice! I remember there was also an issue with grafted subgraphs being renamed. What's the plan to make those work? |
From what we've seen, the problem with grafting is tied to Graph Node's redeployments. So it's likely that the fix will come from that end. The error some indexers were seeing was:
It looks like Graph Node attempts to validate the subgraph manifest before it realizes it already has the deployment in place. The error shouldn't occur again as the migration that caused the problem has been discarded, and this PR won't reintroduce that behavior. |
Related: graphprotocol/graph-node#4534 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good! Let's hold off on merging until we have a migration that will rename and delete the old names? |
I think we can close this pull request because #644 has undone most of the work that it was based on. However, once the issue with Graph-Node's redeployment validation is fixed (graphprotocol/graph-node#4534), we can bring back the branches/PRs that were previously reverted. |
PR #615 inadvertently caused the indexer Agent to only handle subgraphs registered in the Network Subgraph, as it can no longer name a subgraph deployment if it's not registered there.
This PR reintroduces a simpler naming scheme based only on the IPFS hash, similar to the previous naming convention, to handle the case of such subgraphs.