Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: receiving Image and other types of message in conversation form #20

Open
baydisng13 opened this issue Jul 31, 2022 · 3 comments
Open
Labels
good first issue Good for newcomers v2 Needs to be fixed before v2

Comments

@baydisng13
Copy link

In conversation form, we can receive a text like

const text = await conversation.form.text();

Can we also receive a photo and other types of message in this format?

@KnorpelSenf
Copy link
Member

Thanks for the suggestion! I'll work on this

@KnorpelSenf KnorpelSenf transferred this issue from grammyjs/grammY Jul 31, 2022
@KnorpelSenf KnorpelSenf changed the title Receiving Image and other types of message in conversation form feat: receiving Image and other types of message in conversation form Jul 31, 2022
@KnorpelSenf
Copy link
Member

There are a lot of ideas what to wait for. This will not be done for 1.0. We should first figure out #11 and then we can look into adding more things. I would be happy to take ideas regarding #11.

@KnorpelSenf KnorpelSenf added the good first issue Good for newcomers label Jul 31, 2022
@KnorpelSenf
Copy link
Member

KnorpelSenf commented Sep 21, 2022

There are a few issues with the existing form controls already. For example, form.text reacts to callback queries because updates types are not checked properly. This should be made consistent first, before adding more features.

Do you have time to work on this? Then I have more time to look into #11 as well as #19 and #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers v2 Needs to be fixed before v2
Projects
No open projects
Status: To do
Development

No branches or pull requests

3 participants