Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GECToR to use latest AllenNLP (inference time only) #166

Open
damien2012eng opened this issue Sep 2, 2022 · 5 comments
Open

Update GECToR to use latest AllenNLP (inference time only) #166

damien2012eng opened this issue Sep 2, 2022 · 5 comments

Comments

@damien2012eng
Copy link

Hello. First of all, thanks for the wonderful work!
Our team is deciding to update GECToR to use latest AllenNLP, so that it can be compatible to our existing system. We understand that it is not an easy job to do the updating for the whole codebase. Therefore, our team comes up a plan to only update the inference part and consumes the pre-trained models. Could you please take a look at and let us know if it makes sense to you? Here

Thanks so much!

@skurzhanskyi
Copy link
Collaborator

Hi @damien2012eng
Great news! Thanks for sharing. In general, the plan looks good to me. I understand why you decided to work only with the inference part. When ready, we will be happy to add your fork/branch to the repository's README.

@skurzhanskyi
Copy link
Collaborator

Checkout gector-fast repository

@damien2012eng
Copy link
Author

@skurzhanskyi I checked out the gector-fast repo. However, it still uses the old Python and legacy version of Pytorch. Besides, our PRs will be ready soon (currently in the internal review).

@skurzhanskyi skurzhanskyi reopened this Oct 8, 2022
@damien2012eng
Copy link
Author

@skurzhanskyi Please review the first PR. Two more PRs are coming!

@Jason3900
Copy link

@skurzhanskyi Please review the first PR. Two more PRs are coming!

I've update the pytorch version and dependencies. You can try it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants