-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octava does not propagate to voices leading to incorrect rendering #127
Comments
There is now a new |
I also encountered this problem |
Note that there is no conflict in your example: \oct is only on voice 1. It requires manual formatting (or a more clever conversion). It looks like there's already manual editing (otherwise I don't understand where the \noteFormat<dx=... comes from). |
I believe the most serious Octava issue in the engine is #134 currently. @zhwei8090 I guess that you are using LibMusicXML... I should cleanup and submit a PR that greatly improves Guido conversion... I'll try doing that ASAP. |
@dfober In fact, the score is like this, there will be conversion problems when there are multiple voices |
@arshiacont Yes, looking forward to your PR |
@zhwei8090 better support for Octava is now available in xml2guido. It uses the new I believe an ideal solution would be to have as many Octava on different voices and have the rendering engine somehow "merge" those octavas into the best one and finding the most suitable |
@arshiacont I don't know how to describe this problem, it is certain to show a logical problem |
@arshiacont |
looking at the gmn code, it see the following for the first voice:
thus the engine shows what is written. ps: it would be nice to reduce the code to the minimum that reproduces the problem, you would probably have discovered the same thing in this case |
@zhwei8090 I have seen this before and it is an error that sometimes Finale introduces when encoding to MusicXML! If you look at the content of the MusicXML you'll see that it is actually closing early. If this is not the case, create a new ticket on LibMusicXML repo. Keeping this ticket open as the multi-voice Octava is still an issue to be resolved (since using the current "hidden" parameter) does not really solve the problem. Ideally the engine should see all GROctavas and only draw the longest on the voice?!? |
@arshiacont @dfober It has been verified that there is indeed a problem when finale exports the xml, and re-editing the xml can solve it |
@arshiacont @dfober Have you encountered this problem? #144 |
Octava command does not seem to be effective across voices and repeating it will create more visual elements which is not intended.
Consider this score excerpt:
How would one notate the Octava in Guido? so that it takes effect on both voices?
Here are two failing attempts:
(1) Octava on first voice:
(2) Octava on both voices:
The text was updated successfully, but these errors were encountered: