Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for revoking tokens #298

Open
alvarosanchez opened this issue Aug 29, 2016 · 5 comments
Open

Add support for revoking tokens #298

alvarosanchez opened this issue Aug 29, 2016 · 5 comments

Comments

@alvarosanchez
Copy link
Contributor

No description provided.

@alvarosanchez alvarosanchez added this to the 2.0.0.M3 milestone Aug 29, 2016
@jeffbliss
Copy link

Hi!

I just wanted to ask what the status of this issue was and if there was anything I could do to help with this? My colleagues and I are highly interested in this functionality and would love to provide any help if possible.

@alvarosanchez
Copy link
Contributor Author

It's planned for the next milestone. You can track its progress at https://github.com/alvarosanchez/grails-spring-security-rest/milestone/39

@antondelpiero
Copy link

I'm not being pushy or anything and I know you all really busy with Micronaut stuffs, but do you have a time frame about this feature? Its almost 2 years since the last reply :)

Thx again

@alvarosanchez alvarosanchez removed this from the 3.0.0 milestone Feb 13, 2020
@longwa
Copy link
Contributor

longwa commented Apr 2, 2020

There's already partial support for revoking tokens. You just have to implement the tokenStorageService.removeToken method to add to your own block list and then override the loadUserByToken method to check the tokenValue for the block list before returning the UserDetails.

Although, there is one bit missing from this. The default RestLogoutFilter (which we want to use to blacklist tokens when the user explicitly logs out), doesn't call removeToken for the refreshToken, only the accessToken.

I think it should also call tokenStorageService.removeToken for accessToken.refreshToken as well, otherwise if someone has stolen the token, they can just use the refreshToken to request a new one.

I can submit a PR for this if it's helpful.

@jdaugherty
Copy link
Contributor

#521 will add the necessary endpoints to implement revocation support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants