Creating the Proxy fails if Grails-Service is in a plugin

[yvesf]

In AclAutoProxyCreator#afterPropertiesSet a list of beanNames is collected from the service class names.

This list is later used to decide about creating a proxy for this bean in getAdvicesAndAdvisorsForBean.

The name matching fails for all services that are not declared directly in the project but in a grails plugin.
See ServicesGrailsPlugin line 62: If the service class is defined in a plugin then the plugin-name is prepended to the bean name.
Finally the names won't match. To me it looks like it could be corrected by employing the same logic as in the ServicesGrailsPlugin for the naming beans when creating the beanNames list.

In consequence of this problem annotations such as @PreAuthorize are just ignored on these services (depending on your code it can have an impact on application security).

In my particular use-case I'll refactor to not use annotations in the plugin, so I leave this github-issue here just as a hint for others.

[gelleouet]

To bypass this bug, you can declare your own MyAclAutoProxyCreator extends AclAutoProxyCreator and only override afterPropertiesSet method :

@Override
    void afterPropertiesSet() {
        for (GrailsClass serviceClass in grailsApplication.getArtefacts(ServiceArtefactHandler.TYPE)) {
            // old instruction bug
            //String beanName = GrailsNameUtils.getPropertyNameRepresentation(serviceClass.clazz.name)

            // new instruction
            // copy from @see org.grails.plugins.services.ServicesGrailsPlugin
            String beanName = null
            GrailsPlugin providingPlugin = pluginManager.getPluginForClass(serviceClass.getClazz())

            if (providingPlugin && !serviceClass.shortName.toLowerCase().startsWith(providingPlugin.name.toLowerCase())) {
                beanName = "${providingPlugin.name}${serviceClass.shortName}"
            } else {
                beanName = serviceClass.propertyName
            }

            if (shouldProxy(serviceClass.clazz, beanName)) {
                serviceBeanNames << beanName
            }
        }
    }

To finish and use your bean, just overload ACL bean name in Spring beans declarations (or a doWithSpring() plugin) with

securedBeansInterceptor(MyAclAutoProxyCreator) {
  grailsApplication = grailsApplication
  pluginManager = pluginManager
  interceptorNames = ['methodSecurityInterceptor']
  proxyTargetClass = true
}

Note that you have to inject a pluginManager bean.

With this method, you can continue to use ACL annotations without refactoring your code and without big changes

[puneetbehl]

@gelleouet Would you be interested in sending a PR with this change?