Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename /integration to /e2etests #467

Open
ooq opened this issue Feb 12, 2020 · 1 comment
Open

Rename /integration to /e2etests #467

ooq opened this issue Feb 12, 2020 · 1 comment

Comments

@ooq
Copy link
Contributor

ooq commented Feb 12, 2020

Is your feature request related to a problem? Please describe.
Currently, integration tests in Kritis means two things:

  1. The integration tests that live inside each individual package. For example, for the containeranalysis package, the integration tests are here.
  2. Tests under /integration folder. These tests are run on a GKE cluster to test the end-to-end functionality of Kritis.

When we talk about integration tests, it is easy to confuse the two.

Describe the solution you'd like

I propose to rename the tests in /integration folder as end to end tests, or e2e tests, and rename the folder as so. We probably also want to change the build tag in /integration/run_tests.go to e2e as well.

Describe alternatives you've considered
Do nothing.

Additional context
Add any other context or screenshots about the feature request here.

@ooq
Copy link
Contributor Author

ooq commented Feb 12, 2020

cc @nenaddedic @aysylu @acamadeo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant