Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryfrontend: adapt to tempo-query standalone change #1025

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

frzifus
Copy link
Collaborator

@frzifus frzifus commented Aug 30, 2024

Makefile Outdated Show resolved Hide resolved
@frzifus frzifus force-pushed the bump/tempo-query branch 2 times, most recently from b3135a2 to 95677bf Compare September 4, 2024 10:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.08%. Comparing base (e312c82) to head (e8559ee).

Files with missing lines Patch % Lines
apis/config/v1alpha1/projectconfig_types.go 0.00% 1 Missing ⚠️
internal/manifests/queryfrontend/query_frontend.go 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   72.92%   73.08%   +0.16%     
==========================================
  Files         106      106              
  Lines        6577     6624      +47     
==========================================
+ Hits         4796     4841      +45     
- Misses       1491     1493       +2     
  Partials      290      290              
Flag Coverage Δ
unittests 73.08% <96.77%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frzifus frzifus force-pushed the bump/tempo-query branch 3 times, most recently from 4f6a491 to d27e877 Compare September 5, 2024 13:36
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
@rubenvp8510 rubenvp8510 merged commit 21054a4 into grafana:main Sep 6, 2024
11 checks passed
@frzifus frzifus deleted the bump/tempo-query branch September 6, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants