Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update helm release workflow with github app secrets #3631

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

marcsanmi
Copy link
Contributor

@marcsanmi marcsanmi commented Oct 16, 2024

Update helm release workflow to use GitHub App for authentication.
Added GH_RELEASES_APP_ID and GH_RELEASES_APP_PRIVATE_KEY as repository secrets.

Closes https://github.com/grafana/pyroscope-squad/issues/245.

@marcsanmi marcsanmi force-pushed the marcsanmi/use-helm-vault-secrets branch from 4dca52d to 9b0556b Compare October 16, 2024 11:00
@marcsanmi marcsanmi force-pushed the marcsanmi/use-helm-vault-secrets branch from 9b0556b to 2fe96ca Compare October 17, 2024 07:19
@marcsanmi marcsanmi marked this pull request as ready for review October 17, 2024 07:19
@marcsanmi marcsanmi requested a review from a team as a code owner October 17, 2024 07:19
@marcsanmi marcsanmi changed the title chore: leverage vault secrets in helm release chore: update helm release workflow with github app secrets Oct 17, 2024
@marcsanmi marcsanmi merged commit fd82271 into main Oct 17, 2024
18 checks passed
@marcsanmi marcsanmi deleted the marcsanmi/use-helm-vault-secrets branch October 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants