Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address js dependency security issues #2205

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

darrenjaneczek
Copy link
Collaborator

@darrenjaneczek darrenjaneczek commented Aug 3, 2023

trivy filesystem ./yarn.lock

In next, it yields:

Total: 17 (UNKNOWN: 0, LOW: 2, MEDIUM: 7, HIGH: 7, CRITICAL: 1)

See comments below for updated trivy reports.

@darrenjaneczek darrenjaneczek requested a review from a team as a code owner August 3, 2023 21:10
@darrenjaneczek
Copy link
Collaborator Author

The loader-utils was causing issues, so I reverted it for now.

Here is the current report:

Total: 2 (UNKNOWN: 0, LOW: 0, MEDIUM: 1, HIGH: 0, CRITICAL: 1)

┌──────────────────┬────────────────┬──────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────────┐
│     Library      │ Vulnerability  │ Severity │ Installed Version │ Fixed Version │                            Title                            │
├──────────────────┼────────────────┼──────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤
│ @cypress/request │ CVE-2023-28155 │ MEDIUM   │ 2.88.11           │ 3.0.0         │ The Request package through 2.88.1 for Node.js allows a     │
│                  │                │          │                   │               │ bypass of SSRF...                                           │
│                  │                │          │                   │               │ https://avd.aquasec.com/nvd/cve-2023-28155                  │
├──────────────────┼────────────────┼──────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤
│ loader-utils     │ CVE-2022-37601 │ CRITICAL │ 0.2.17            │ 1.4.1, 2.0.3  │ prototype pollution in function parseQuery in parseQuery.js │
│                  │                │          │                   │               │ https://avd.aquasec.com/nvd/cve-2022-37601                  │
└──────────────────┴────────────────┴──────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────────┘

@darrenjaneczek
Copy link
Collaborator Author

darrenjaneczek commented Aug 28, 2023

Found a better compromise:

Total: 1 (UNKNOWN: 0, LOW: 0, MEDIUM: 1, HIGH: 0, CRITICAL: 0)

┌──────────────────┬────────────────┬──────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────┐
│     Library      │ Vulnerability  │ Severity │ Installed Version │ Fixed Version │                          Title                          │
├──────────────────┼────────────────┼──────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────┤
│ @cypress/request │ CVE-2023-28155 │ MEDIUM   │ 2.88.11           │ 3.0.0         │ The Request package through 2.88.1 for Node.js allows a │
│                  │                │          │                   │               │ bypass of SSRF...                                       │
│                  │                │          │                   │               │ https://avd.aquasec.com/nvd/cve-2023-28155              │
└──────────────────┴────────────────┴──────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────┘

Given the cypress is not an actual runtime dependency (dev dependency for testing only), I am not worried about this warning. We can address this later once we bring cypress testing back online.

@darrenjaneczek darrenjaneczek enabled auto-merge (squash) August 28, 2023 17:12
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darrenjaneczek darrenjaneczek merged commit 8a99ada into next Aug 28, 2023
14 checks passed
@darrenjaneczek darrenjaneczek deleted the chore/npm-dependency-security branch August 28, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants