OG Go code cleanup #2017
Merged
OG Go code cleanup #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petethepig
changed the title
korniltsev
reviewed
Jul 19, 2023
| @@ -343,7 +344,6 @@ github.com/chzyer/readline v1.5.1/go.mod h1:Eh+b79XXUwfKfcPLepksvw2tcLE/Ct21YObk | |||
| github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1 h1:q763qf9huN11kDQavWsoZXJNW3xEE4JJyHa5Q25/sd8= | |||
| github.com/chzyer/test v1.0.0 h1:p3BQDXSxOhOG0P9z6/hGnII4LGiEPOYBhs8asl/fC04= | |||
| github.com/chzyer/test v1.0.0/go.mod h1:2JlltgoNkt4TW/z9V/IzDdFaMTM2JPIi26O1pF38GC8= | |||
| github.com/cilium/ebpf v0.11.0/go.mod h1:WE7CZAnqOL2RouJ4f1uyNhqr2P4CCvXFIqdRDUgWsVs= | |||
There was a problem hiding this comment.
I wonder why is it deleted? o_O
I'd expect it to be still used https://github.com/grafana/pyroscope/blob/next/ebpf/go.mod#L7
There was a problem hiding this comment.
Personally not too familiar with workspaces, but according to stackoverflow go.work.sum.
It would only contain things not contained/different from the referenced modules in go.work.
As epbf/go.sum contains this particular sum it can be removed. I also think our PR ci doesn't do a go mod tidy check yet on ebpf. That would also explain why it has been added in the first place.
There was a problem hiding this comment.
This should prevent it going forward: #2020
simonswine
approved these changes
Jul 19, 2023
kolesnikovae
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2010
This PR:
og/pkgtopkg/ogpyroscope-io/pyroscopedependency