Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix protobufjs version #2005

Merged
merged 4 commits into from
Jul 18, 2023
Merged

chore: fix protobufjs version #2005

merged 4 commits into from
Jul 18, 2023

Conversation

darrenjaneczek
Copy link
Collaborator

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 998.75 KB (0%) 20 s (0%) 3.5 s (-13.68% 🔽) 23.5 s
webapp/public/assets/app.css 19.9 KB (0%) 399 ms (0%) 0 ms (+100% 🔺) 399 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 625.75 KB (0%) 12.6 s (0%) 1.7 s (-2.73% 🔽) 14.2 s
packages/pyroscope-flamegraph/dist/index.node.js 626.46 KB (0%) 12.6 s (0%) 942 ms (+5.71% 🔺) 13.5 s
packages/pyroscope-flamegraph/dist/index.css 8.14 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@darrenjaneczek darrenjaneczek mentioned this pull request Jul 17, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@808adf0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2005   +/-   ##
=======================================
  Coverage        ?   60.43%           
=======================================
  Files           ?      177           
  Lines           ?     4999           
  Branches        ?     1158           
=======================================
  Hits            ?     3021           
  Misses          ?     1966           
  Partials        ?       12

@darrenjaneczek darrenjaneczek marked this pull request as ready for review July 17, 2023 19:25
Rperry2174
Rperry2174 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

abannachGrafana
abannachGrafana approved these changes Jul 18, 2023
View reviewed changes
Copy link

@abannachGrafana abannachGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenjaneczek darrenjaneczek merged commit e0bf410 into main Jul 18, 2023
18 of 20 checks passed
@darrenjaneczek darrenjaneczek deleted the chore/dependency-fix-protobufjs-force-version branch July 18, 2023 13:32
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jul 20, 2023
@darrenjaneczek @simonswine
chore: fix protobufjs version (grafana#2005)
c6f594f 
* chore: fix protobufjs version

* fix: pin dependency resolution on example code
simonswine pushed a commit that referenced this pull request Jul 20, 2023
@darrenjaneczek @simonswine
chore: fix protobufjs version (#2005)
f0e48af 
* chore: fix protobufjs version

* fix: pin dependency resolution on example code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rperry2174 Rperry2174 Rperry2174 approved these changes

@abannachGrafana abannachGrafana abannachGrafana approved these changes

Assignees
No one assigned
Labels
has conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darrenjaneczek @codecov-commenter @Rperry2174 @abannachGrafana