chore: fix d3-color version to 3.1.0 #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
Codecov Report
@@ Coverage Diff @@
## main #2002 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 177 177
Lines 4999 4999
Branches 1158 1158
=======================================
Hits 3021 3021
Misses 1966 1966
Partials 12 12 |
size-limit report 📦
|
darrenjaneczek
force-pushed
the
chore/dependency-fix-d3-color
branch
from
e51cc21
to
b119526
Compare
Flamegraph.com reportCreated by Flamegraph.com Github Action |
| @@ -8879,7 +8879,7 @@ d3-chord@3: | |||
| d3-path "1 - 3" | |||
|
|
|||
| "d3-color@1 - 3", d3-color@3: | |||
| version "3.0.1" | |||
| version "3.1.0" | |||
| resolved "https://registry.yarnpkg.com/d3-color/-/d3-color-3.0.1.tgz#03316e595955d1fcd39d9f3610ad41bb90194d0a" | |||
There was a problem hiding this comment.
- Is d3-color a transitive dependency?
- does the version in this
resolvedurl need updating?
There was a problem hiding this comment.
Could you use the resolutions block in the package.json to codify this change? Just concerned that a different package.json change will re-resolve this back to the old version.
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 20, 2023
simonswine
pushed a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.