Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adhoc readme for more adhoc modes #1985

Merged
merged 11 commits into from
Jul 11, 2023
Merged

Update adhoc readme for more adhoc modes #1985

merged 11 commits into from
Jul 11, 2023

Conversation

Rperry2174
Copy link
Contributor

@korniltsev can you please help me make the docs more generic / make sense to run from scratch in our examples folder?
i.e. pyroscope-cli vs ./bin/pyroscope which one should I use? Should I already have both downloaded, etc.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 998.48 KB (0%) 20 s (0%) 4.6 s (+19.12% 🔺) 24.6 s
webapp/public/assets/app.css 19.9 KB (0%) 399 ms (0%) 0 ms (+100% 🔺) 399 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 625.75 KB (0%) 12.6 s (0%) 1.8 s (+17.28% 🔺) 14.3 s
packages/pyroscope-flamegraph/dist/index.node.js 626.45 KB (0%) 12.6 s (0%) 1.1 s (-3.93% 🔽) 13.6 s
packages/pyroscope-flamegraph/dist/index.css 8.14 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

examples/adhoc/README.md Outdated Show resolved Hide resolved
examples/adhoc/README.md Outdated Show resolved Hide resolved
examples/adhoc/README.md Outdated Show resolved Hide resolved
examples/adhoc/README.md Outdated Show resolved Hide resolved
examples/adhoc/README.md Show resolved Hide resolved
examples/adhoc/README.md Outdated Show resolved Hide resolved
examples/adhoc/README.md Outdated Show resolved Hide resolved
examples/adhoc/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

examples/adhoc/README.md Outdated Show resolved Hide resolved
Co-authored-by: Tolya Korniltsev <[email protected]>
@Rperry2174 Rperry2174 merged commit 408ab35 into main Jul 11, 2023
16 of 17 checks passed
@Rperry2174 Rperry2174 deleted the update-adhoc-docs branch July 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants