Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullnameOverride mixing in helm subcharts #9564

Open
elsoa-invitech opened this issue Oct 8, 2024 · 1 comment · May be fixed by #9565
Open

fullnameOverride mixing in helm subcharts #9564

elsoa-invitech opened this issue Oct 8, 2024 · 1 comment · May be fixed by #9565
Labels
bug Something isn't working helm

Comments

@elsoa-invitech
Copy link

Describe the bug

If you set the fullnameOverride for mimir and for subcharts, some manifests are generated bad.

To Reproduce

Sample values.yaml:

---
fullnameOverride: grafana-mimir
minio:
  fullnameOverride: grafana-mimir-minio

Generate the manifest:
helm template --dry-run --debug -f values.yaml --repo https://grafana.github.io/helm-charts mimir-distributed --name-template csiga --output-dir out

Check the main templates, its good:

$ grep " name:" out/mimir-distributed/templates/runtime-configmap.yaml 
  name: grafana-mimir-runtime

Check a minio template, its good:

$ grep " name:" out/mimir-distributed/charts/minio/templates/configmap.yaml 
  name: grafana-mimir-minio

But some template have bad reference, like:

$ grep -A1 configMap out/mimir-distributed/templates/minio/create-bucket-job.yaml 
            - configMap:
                name: csiga-minio

Expected behavior

create-bucket-job.yaml sould have configmap name: grafana-mimir-minio

Environment

  • Infrastructure: kubernetes
  • Deployment tool: helm
@elsoa-invitech
Copy link
Author

Same issue exist in minio service ref:
This is the minio service name:

$ grep " name:" out/mimir-distributed/charts/minio/templates/service.yaml 
  name: grafana-mimir-minio

And the mimir-config endpoint is wrong:

$ grep csiga- out -R
out/mimir-distributed/templates/mimir-config.yaml:        endpoint: csiga-minio.default.svc:9000
out/mimir-distributed/templates/mimir-config.yaml:        endpoint: csiga-minio.default.svc:9000
out/mimir-distributed/templates/mimir-config.yaml:        endpoint: csiga-minio.default.svc:9000

This sould be grafana-mimir-minio.default.svc

@elsoa-invitech elsoa-invitech linked a pull request Oct 8, 2024 that will close this issue
@56quarters 56quarters added bug Something isn't working helm labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants