-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test flake: TestDistributor_Push_ShouldSupportWriteBothToIngestersAndPartitions #9299
Labels
Comments
4 tasks
i couldn't reproduce after about 600 runs. After reducing the time to poll from kafka from 1s to 10ms I could get a similar failure: although there it's missing all 3 partitions, not just 2/3. diff --git a/pkg/distributor/distributor_ingest_storage_test.go b/pkg/distributor/distributor_ingest_storage_test.go
index b598ac6a8f..0ac85ac77a 100644
--- a/pkg/distributor/distributor_ingest_storage_test.go
+++ b/pkg/distributor/distributor_ingest_storage_test.go
@@ -451,7 +451,7 @@ func TestDistributor_Push_ShouldSupportWriteBothToIngestersAndPartitions(t *test
require.NoError(t, err)
// Ensure series has been correctly sharded to partitions.
- actualSeriesByPartition := readAllMetricNamesByPartitionFromKafka(t, kafkaCluster.ListenAddrs(), testConfig.ingestStoragePartitions, time.Second)
+ actualSeriesByPartition := readAllMetricNamesByPartitionFromKafka(t, kafkaCluster.ListenAddrs(), testConfig.ingestStoragePartitions, time.Second/100)
assert.Equal(t, testData.expectedMetricsByPartition, actualSeriesByPartition)
// Ensure series have been correctly sharded to ingesters. Failure
I opened a PR to log the end offsets of the topic on a failure: #9323 so we can verify if the timeout is just too tight |
happened again Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Received a test flake in CI: https://github.com/grafana/mimir/actions/runs/10856690387/job/30131835759#step:8:136
Environment
Github actions CI.
The text was updated successfully, but these errors were encountered: