Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase the limit for query length from 5k to 128k #13220

Closed
wants to merge 1 commit into from
Closed

fix: increase the limit for query length from 5k to 128k #13220

wants to merge 1 commit into from

Conversation

xperimental
Copy link
Collaborator

What this PR does / why we need it:

This PR backports the increase in query length limit introduced in #11701 to the 2.9.x Loki release.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Title matches the required conventional commits format, see here

@xperimental xperimental requested a review from a team as a code owner June 14, 2024 12:54
@xperimental
Copy link
Collaborator Author

As far as I know, we plan to roll out this change on our end by updating to Loki 3.1 soon.

Do we still want to merge this change to 2.9 or drop it?

chaudum
chaudum reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add a note to the upgrade guide even though the change is loosening the limitation.

@xperimental
Copy link
Collaborator Author

Dropping this change, as we currently do not see a need for this backport.

@xperimental xperimental deleted the backport-limit-increase branch July 22, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum left review comments

@periklis periklis periklis approved these changes

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xperimental @periklis @chaudum @JoaoBraveCoding @slim-bean