Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki Query Frontend Error "query filtering for deletes requires 'compactor_grpc_address' or 'compactor_address' to be configured" #10128

Open
17billion opened this issue Aug 1, 2023 · 3 comments
Labels
type/bug Somehing is not working as expected

Comments

@17billion
Copy link

17billion commented Aug 1, 2023

Describe the bug:
Pod startup failed after helm installs loki, The error is CrashLoopBackOff,
err="query filtering for deletes requires 'compactor_grpc_address' or 'compactor_address' to be configured

I am using version 2.7.5 with the following configuration:

limits_config:
...
  deletion_mode: disabled
...
compactor:
...
  retention_enabled: false

After adding the above configuration, I encounter the following error(querier, query-frontend):

level=warn ts=2023-08-01T10:35:17.299890182Z caller=loki.go:251 msg="per-tenant timeout not configured, using default engine timeout (\"5m0s\"). This behavior will change in the next major to always use the default per-tenant timeout (\"5m\")."
query filtering for deletes requires 'compactor_grpc_address' or 'compactor_address' to be configured
error initialising module: cache-generation-loader
github.com/grafana/dskit/modules.(*Manager).initModule
	/src/loki/vendor/github.com/grafana/dskit/modules/modules.go:122
github.com/grafana/dskit/modules.(*Manager).InitModuleServices
	/src/loki/vendor/github.com/grafana/dskit/modules/modules.go:92
github.com/grafana/loki/pkg/loki.(*Loki).Run
	/src/loki/pkg/loki/loki.go:422
main.main
	/src/loki/cmd/loki/main.go:110
runtime.main
	/usr/local/go/src/runtime/proc.go:250
runtime.goexit
	/usr/local/go/src/runtime/asm_arm64.s:1172
level=info ts=2023-08-01T10:35:17.497084809Z caller=main.go:108 msg="Starting Loki" version="(version=2.7.5, branch=HEAD, revision=fd33f6a18)"
level=error ts=2023-08-01T10:35:17.497180898Z caller=log.go:171 msg="error running loki" err="query filtering for deletes requires 'compactor_grpc_address' or 'compactor_address' to be configured\nerror initialising module: cache-generation-loader\ngithub.com/grafana/dskit/modules.(*Manager).initModule\n\t/src/loki/vendor/github.com/grafana/dskit/modules/modules.go:122\ngithub.com/grafana/dskit/modules.(*Manager).InitModuleServices\n\t/src/loki/vendor/github.com/grafana/dskit/modules/modules.go:92\ngithub.com/grafana/loki/pkg/loki.(*Loki).Run\n\t/src/loki/pkg/loki/loki.go:422\nmain.main\n\t/src/loki/cmd/loki/main.go:110\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:250\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_arm64.s:1172"
Could not flush logger <nil>

Everything works fine until I add the following section.

common:
  compactor_grpc_address: loki-compactor:3100

But I don't understand why this is required. Is there any other use case where compactor_grpc_address or compactor_address is needed?

Currently I am upgrading from 2.6.1 to 2.7.5 and nothing has changed in my existing settings.
In addition, it seems that deletion_mode was disabled in the past 2.6.1.(https://github.com/grafana/loki/blob/v2.6.1/docs/sources/configuration/_index.md) Is there a reason why it was changed to filter-and-delete in the 2.7.x version?(https://github.com/grafana/loki/blob/v2.7.0/docs/sources/configuration/_index.md)
In my understanding, adding the compactor endpoint in the configuration seems to signal that the deletion is possible, and I don't want to add it.

Similar issues

Tasks

No tasks being tracked yet.
@17billion
Copy link
Author

Looking at the source below, if retention_enabled is disabled, the above error should not occur.

@17billion
Copy link
Author

The strange thing is that Ruler is also used, but the above error does not occur under the same conditions.

@JStickler JStickler added the type/bug Somehing is not working as expected label Aug 2, 2023
@fragolinux
Copy link

got same error here, just in the "read" pods after deploying chart v3.0.0 and loki 3.0.0: #12594 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Somehing is not working as expected
Projects
None yet
Development

No branches or pull requests

3 participants