Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not freeze SharedArray items #4051

Open
mstoykov opened this issue Nov 11, 2024 · 0 comments
Open

Add option to not freeze SharedArray items #4051

mstoykov opened this issue Nov 11, 2024 · 0 comments
Labels

Comments

@mstoykov
Copy link
Contributor

Feature Description

Currently items out of SharedArray are frozen.

This was done predominantly to prevent people from thinking that editing them will have effect across iterations or VUs.

Unfortunately there are two side effects:

  1. It does actually require time to freeze items as seen in SharedArray: Bad performance with big items #3237
  2. if you will get an item and then edit it before doing something, you now need to make another copy

Suggested Solution (optional)

Add an option when making(?) the SharedArray to say that you do not want items to be frozen.

OR

Do not freeze any of the items to begin with

OR

Combine the above two - make SharedArray not freeze by default but add an option.

I personally think that we should go with option 1 for now and just add a new option. It is still likely better for most users to get them frozen and not turn out users are confused about.

Already existing or connected issues / PRs (optional)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant