Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include group in check metrics #2980

Closed
michael-sw-id opened this issue Mar 16, 2023 · 6 comments
Closed

Include group in check metrics #2980

michael-sw-id opened this issue Mar 16, 2023 · 6 comments
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature metrics-output Issues related to the metrics output (a.k.a. just output) statsd Something related to the statsd

Comments

@michael-sw-id
Copy link

michael-sw-id commented Mar 16, 2023

Feature Description

Currently metrics for checks are generated as k6.check.expected_Expect_HttpStatus_to_equal_201.pass

It would be great if metrics include the group e.g.

k6.check.group_create_customer.expected_Expect_HttpStatus_to_equal_201.pass

Ideally should also support nested groups e.g.

  • Onboard customer journey
    - Submit Identity Card
    - Register Password
    - Accept T&C

Suggested Solution (optional)

Given this is a breaking change for existing dashboards or consumers of these metrics, would probably need to put it behind some feature flag/configuration.

Already existing or connected issues / PRs (optional)

No response

@imiric
Copy link
Contributor

imiric commented Mar 22, 2023

Hi there, thanks for opening this issue.

Judging by the metric name, I assume you're using the statsd output, right? Are you sending metrics to Datadog or New Relic?

While this seems like a useful suggestion, it needs some evaluation, so we're unlikely to implement it anytime soon.

For one, it would be a breaking change for users who don't expect to have group names in check metrics. This could be mitigated by making the behavior optional, but we wouldn't want to complicate the configuration any further.

Also, we're currently evaluating the status and future of StatsD outputs, and we might decide to make individual backend extensions, or deprecate support for it altogether. Since it's in a state of flux, it's unlikely we'll make any changes to it while it remains part of k6.

So we'll keep this issue open and look into it, but no guarantees it will be implemented.

@imiric imiric added the evaluation needed proposal needs to be validated or tested before fully implementing it in k6 label Mar 22, 2023
@michael-sw-id
Copy link
Author

yep, statsd with datadog

@nilesh05apr
Copy link

Hi @imiric can i try this?

To implement this change, we can introduce a new configuration option in k6 that enables this feature. For example, we can add a flag like --enable-check-groups that would modify the metric names to include the group information.

I am not sure about the nested subgroups right now. But we can proceed similarly for them as well.
Please let me know what are your thoughts on this.

@imiric
Copy link
Contributor

imiric commented May 2, 2023

@nilesh05apr Thanks for offering to help, and feel free to work on it in your k6 fork, but we're not likely to merge any changes to the statsd output because of what I mentioned above. Adding a new CLI flag would also be problematic because of #883.

@olegbespalov olegbespalov added metrics-output Issues related to the metrics output (a.k.a. just output) statsd Something related to the statsd labels Jul 12, 2024
@LeonAdato
Copy link

Per @olegbespalov and @javaducky, this issue should probably be part of the StatsD project. Feel free to transfer it here:

https://github.com/LeonAdato/xk6-output-statsd

@olegbespalov
Copy link
Contributor

Closing in favor of LeonAdato/xk6-output-statsd#23

@olegbespalov olegbespalov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
@olegbespalov olegbespalov removed their assignment Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature metrics-output Issues related to the metrics output (a.k.a. just output) statsd Something related to the statsd
Projects
None yet
Development

No branches or pull requests

6 participants