Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new otelcol.exporter.debug component #301

Closed
ptodev opened this issue Nov 24, 2023 · 5 comments · Fixed by BarunKGP/grafana-agent#1, grafana/agent#5867 or BarunKGP/grafana-agent#2
Assignees
Labels
enhancement New feature or request frozen-due-to-age good first issue Good for newcomers

Comments

@ptodev
Copy link
Contributor

ptodev commented Nov 24, 2023

Request

We need to add a new otelcol.exporter.debug component based on the debug exporter. We should also deprecate otelcol.exporter.logging by adding a "warning" message in its doc that the component is deprecated and may be removed around October 2024.

Use case

OpenTelemetry Collector's logging exporter has been deprecated in favour of the new debug exporter.

@ptodev ptodev added enhancement New feature or request good first issue Good for newcomers labels Nov 24, 2023
@BarunKGP
Copy link

BarunKGP commented Nov 25, 2023

@ptodev could you please assign this to me? I plan to take a stab at it this weekend.

@ptodev
Copy link
Contributor Author

ptodev commented Nov 25, 2023

@BarunKGP - Of course! Thank you!

@BarunKGP
Copy link

@ptodev thanks for assigning this to me! I've already set up the code, and I'll open a PR for it soon.

I was wondering whether I should create a separate PR documenting the logging exporter deprecation warning, or would it make sense to simply add it in this one?

@ptodev
Copy link
Contributor Author

ptodev commented Nov 28, 2023

@BarunKGP thank you for your PR! It is ok to add the warning in the same PR (#5867).

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.