Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document environment variables alongside relevant config #245

Closed
ptodev opened this issue Feb 15, 2024 · 5 comments · Fixed by #1137
Closed

Document environment variables alongside relevant config #245

ptodev opened this issue Feb 15, 2024 · 5 comments · Fixed by #1137
Assignees
Labels
enhancement New feature or request frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos

Comments

@ptodev
Copy link
Contributor

ptodev commented Feb 15, 2024

Request

There are various environment variables (mostly from Go) which can affect the Agent's behaviour. Currently, those are not documented anywhere. It would be nice to add them in a new section in the Command-line interface docs. Component reference docs such as tls config block can then point to relevant sections of that env var doc.

Use case

For example:

@ptodev ptodev added enhancement New feature or request type/docs Docs Squad label across all Grafana Labs repos labels Feb 15, 2024
@clayton-cornell clayton-cornell self-assigned this Feb 15, 2024
@clayton-cornell
Copy link
Contributor

Moved to backlog. This is a future fix once higher priority doc fixes are in-place

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@clayton-cornell
Copy link
Contributor

@ptodev Where can I find the env vars we use?

@ptodev
Copy link
Contributor Author

ptodev commented May 15, 2024

There isn't an easy way to find them. Unlike cmd args, env vars could be referenced anywhere in the code, including in libraries which we import. This is what makes having a doc page important :)

It's not necessary to have an exhaustive list. The main goals are:

  • Making a space in the documentation for env vars, so that we know where to document them as time goes on.
  • Documenting the most important ones (which are probably the ones listed in this issue).

@clayton-cornell
Copy link
Contributor

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants