fix tls condition for kafka_exporter, issue #6048 #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
in my opinion need to remove this condition completely |
|
This PR has not had any activity in the past 30 days, so the |
github-actions
bot
added
the
needs-attention
rfratto
added
variant/static
github-actions
bot
removed
the
needs-attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
try to fix issue 6048
Which issue(s) this PR fixes
grafana/alloy#280
Notes to the Reviewer
original kafka exporter allow connect without cert&key pair only with root ca
(sorry, english is not my main language)
UP: checked, it's work