fix(flow): ensure format consistency for all emitted logs #5992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
reviewed
Jan 9, 2024
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
ensure-log-format-consistency
branch
from
211479f
to
ba5646e
Compare
rfratto
reviewed
Feb 5, 2024
wildum
requested changes
Feb 5, 2024
wildum
reviewed
Feb 5, 2024
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
wildum
reviewed
Feb 5, 2024
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
wildum
reviewed
Feb 7, 2024
… main logger Signed-off-by: hainenber <[email protected]>
wildum
reviewed
Feb 7, 2024
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
wildum
approved these changes
Feb 20, 2024
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Ensure log format consistency for all logs emitted by the agent by ensuring
loggingblock got evaluated firstly and re-order possibly inconsistent log sources.Which issue(s) this PR fixes
Fixes #5969
Notes to the Reviewer
Is there any harm in evaluating the
loggingblock twice? My naive assumption is No but would like you guys got more ctx on me on this :DPR Checklist