Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows fork #5784

Merged
merged 13 commits into from
Nov 16, 2023
Merged

Remove windows fork #5784

merged 13 commits into from
Nov 16, 2023

Conversation

mattdurham
Copy link
Collaborator

PR Description

This removes the reference to the windows_fork. Special shoutout to @jkroepke for work on allowing the windows_exporter to use configuration.

The only real painful point is I had to pin replace golang.org/x/exp => golang.org/x/exp v0.0.0-20230713183714-613f0c0eb8a1 since the sortfunc changed definition in the newest version and loki doesnt handle that.

Which issue(s) this PR fixes

Closes ##3420

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@mattdurham mattdurham requested review from erikbaranowski and removed request for erikbaranowski November 15, 2023 19:24
CHANGELOG.md Outdated Show resolved Hide resolved
@mattdurham mattdurham marked this pull request as ready for review November 15, 2023 20:31
@mattdurham mattdurham merged commit 55b3446 into main Nov 16, 2023
10 checks passed
@mattdurham mattdurham deleted the remove_windows_fork branch November 16, 2023 15:48
@erikbaranowski erikbaranowski mentioned this pull request Dec 7, 2023
4 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants