Remove NeedsServices from components #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the cluster service to stop looking at dependant components when notifying clustered components of a cluster update. Related to grafana#5777, as components will no longer be able to declare a dependancy on a service.
Change the doc comment of service.Data to note that the returned data must not rely on runtime config. Related to grafana#5777, as components will no longer directly depend on services. If service.Data relied on the runtime config, it would open the door for hidden circular dependencies.
This commit fully removes the dependency from components to services, leaving the NeedsServices field in component.Registration ignored. Related to grafana#5777.
Remove the unused NeedsServices field. Related to grafana#5777.
Update the CHANGELOG and docs to reflect the dropped requirement that components must depend on consumed services. Closes grafana#5777.
clayton-cornell
added
the
type/docs
thampiotr
approved these changes
Nov 24, 2023
rfratto
force-pushed
the
remove-needsservices
branch
from
f14219e
to
c3b8c79
Compare
hainenber
pushed a commit
to hainenber/agent
that referenced
this pull request
Nov 25, 2023
* service/cluster: stop using dependant components Update the cluster service to stop looking at dependant components when notifying clustered components of a cluster update. Related to grafana#5777, as components will no longer be able to declare a dependancy on a service. * service: add soft requirement that data must not rely on runtime config Change the doc comment of service.Data to note that the returned data must not rely on runtime config. Related to grafana#5777, as components will no longer directly depend on services. If service.Data relied on the runtime config, it would open the door for hidden circular dependencies. * flow: remove dependency from components to services This commit fully removes the dependency from components to services, leaving the NeedsServices field in component.Registration ignored. Related to grafana#5777. * component: remove NeedsServices field Remove the unused NeedsServices field. Related to grafana#5777. * misc: update CHANGELOG and docs for grafana#5777 Update the CHANGELOG and docs to reflect the dropped requirement that components must depend on consumed services. Closes grafana#5777.
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the NeedsServices field from component registration. See #5777 for context.
I've split the PR across several commits to make it more readable.
Closes #5777.