Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for result paging #3

Open
amotl opened this issue May 7, 2019 · 6 comments
Open

Add support for result paging #3

amotl opened this issue May 7, 2019 · 6 comments
Labels
bug Something isn't working pitch A pitch for a new feature

Comments

@amotl
Copy link
Contributor

amotl commented May 7, 2019

To reach beyond the 5000 results limit employed by Grafana on the dashboard search API, grafana-wtf should apply appropriate paging, see also https://grafana.com/docs/http_api/folder_dashboard_search/.

This request originated at #2, thanks @jangaraj.

@amotl
Copy link
Contributor Author

amotl commented May 8, 2019

@jangaraj: As I learned from your reports, you are operating Grafana setups with more than 1000 dashboards but you have not yet crossed the 5000 dashboard mark, right?

Please let me know if this turns out to be true at some time, then we will add appropriate paging mechanisms to the code.

Cheers!

@jangaraj
Copy link

jangaraj commented May 8, 2019

Yes, my Grafana instance has only 1.3k dashboards.

@amotl amotl added the pitch A pitch for a new feature label Dec 10, 2021
@madhav-prabhu
Copy link

madhav-prabhu commented Jul 17, 2024

@amotl before I ask my ques just wanted to say grafana-wtf has been a lifesaver and a solid tool! 💯

Do you have any plans to introduce paging to go beyond the 5000 dashboard limit? I use grafana-wtf as a part of a larger workflow that analyzes metrics utilization across various datasources, the grafana instance has about 6k dashboards and counting, giving incomplete results

@amotl
Copy link
Contributor Author

amotl commented Sep 19, 2024

Dear @madhav-prabhu,

thanks a stack for writing in, for your kind words, and for outlining that you have a need that this limit needs to be raised. Would you be able to come up with a corresponding patch, or don't you have the capacities for that?

With kind regards,
Andreas.

@amotl amotl added the bug Something isn't working label Sep 19, 2024
@amotl
Copy link
Contributor Author

amotl commented Sep 28, 2024

grafana-client needs to implement the page parameter in search_dashboards().

@amotl
Copy link
Contributor Author

amotl commented Oct 15, 2024

@vbichov just contributed that missing feature at grafana-client. Thanks a stack!

So, we can finally think about adding that missing feature at grafana-wtf as well, probably around that spot:

self.data.dashboard_list = self.grafana.search.search_dashboards(limit=5000)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pitch A pitch for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants