You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
at GH-15, @bukowa asked for some adjustments for their use case. On the other hand, I think the code should probably be validated to work with all of Python 3.11, Grafana 9, and pandas 2.x these days.
I think it will be sweet to integrate those modernizations into the main code base. Maybe you could submit corresponding patches?
With kind regards,
Andreas.
Footnotes
Using f-strings makes sense, and also using some basic list comprehensions like compressing for col in df:. However, I don't like compressing code too much like freq = str(req.get("intervalMs")) + "ms" if "intervalMs" in req else None. ↩
The text was updated successfully, but these errors were encountered:
amotl
changed the title
Modernize code base for pandas 2.x
Modernize code base for pandas 2.x and beyond
Apr 29, 2023
Hi there,
at GH-15, @bukowa asked for some adjustments for their use case. On the other hand, I think the code should probably be validated to work with all of Python 3.11, Grafana 9, and pandas 2.x these days.
Just having a look at two forks of the project, I discovered BP2022-AP1@79ec4cfdcb67 and BP2022-AP1@dd92d43d987 by @LucasDerReisende as well as jakubjezek001@5ca76493bce0e7 by @jakubjezek001 1.
I think it will be sweet to integrate those modernizations into the main code base. Maybe you could submit corresponding patches?
With kind regards,
Andreas.
Footnotes
Using f-strings makes sense, and also using some basic list comprehensions like compressing
for col in df:
. However, I don't like compressing code too much likefreq = str(req.get("intervalMs")) + "ms" if "intervalMs" in req else None
. ↩The text was updated successfully, but these errors were encountered: